Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#572 Convert CSS usage to logical properties #618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#572 Convert CSS usage to logical properties #618

wants to merge 1 commit into from

Conversation

ItielMaN
Copy link
Contributor

No description provided.

@ItielMaN
Copy link
Contributor Author

ItielMaN commented Mar 21, 2020 •
edited
Loading

This fixes #572. Note that this doesn't actually add RTL support.

@maxxcrawford maxxcrawford self-requested a review March 23, 2020 14:38
maxxcrawford
maxxcrawford requested changes Mar 23, 2020
View reviewed changes
src/content_script.css Outdated Show resolved Hide resolved
@maxxcrawford
Copy link
Collaborator

@lesleyjanenorton When trying to test the RTL support, I think the panel doesn't respect RTL. Can you confirm?

image

@ItielMaN
Copy link
Contributor Author

ItielMaN commented Jun 4, 2020

@lesleyjanenorton When trying to test the RTL support, I think the panel doesn't respect RTL. Can you confirm?

image

Yes, that's right.
I don't have sufficient knowledge in JS to add support for that, so this PR is about laying the foundations so that when the panel would have RTL support, everything should magically work wrt CSS stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesleyjanenorton lesleyjanenorton Awaiting requested review from lesleyjanenorton

@maxxcrawford maxxcrawford Awaiting requested review from maxxcrawford

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItielMaN @maxxcrawford